From 4269c69a16f924c11adeedbb31591f6fad9f41b2 Mon Sep 17 00:00:00 2001 From: Kody Stribrny <89810515+kstribrnAmzn@users.noreply.github.com> Date: Thu, 23 Jul 2026 10:32:25 -0700 Subject: [PATCH] Add comment explaining ACL permissions revocation (#1421) Adds a simple comment mentioning the requirement for the privileged task to revoke permissions before deleting an object. --- include/mpu_wrappers.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/mpu_wrappers.h b/include/mpu_wrappers.h index 3de2013ce..ebbd5f940 100644 --- a/include/mpu_wrappers.h +++ b/include/mpu_wrappers.h @@ -250,6 +250,9 @@ #if ( ( configUSE_MPU_WRAPPERS_V1 == 0 ) && ( configENABLE_ACCESS_CONTROL_LIST == 1 ) ) #define vGrantAccessToTask( xTask, xTaskToGrantAccess ) vGrantAccessToKernelObject( ( xTask ), ( int32_t ) ( xTaskToGrantAccess ) ) + +/* A privileged task must revoke access to the object before deletion, + * otherwise index reuse may result in accidental permissions. */ #define vRevokeAccessToTask( xTask, xTaskToRevokeAccess ) vRevokeAccessToKernelObject( ( xTask ), ( int32_t ) ( xTaskToRevokeAccess ) ) #define vGrantAccessToSemaphore( xTask, xSemaphoreToGrantAccess ) vGrantAccessToKernelObject( ( xTask ), ( int32_t ) ( xSemaphoreToGrantAccess ) )