From b72aef2d316c0571eaf6a9e528e759b8e2ba107b Mon Sep 17 00:00:00 2001 From: Aniruddha Joshi Date: Mon, 27 Apr 2026 17:13:58 -0400 Subject: [PATCH] Fix undefined behavior in mbedTLS transport log format specifiers (#1406) * Fix undefined behavior in mbedTLS transport log statements * pNetworkContext now explicitly cast to void pointer * Delete personal fil --- .../network_transport/transport_mbedtls.c | 6 +++--- .../network_transport/transport_mbedtls_pkcs11.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/FreeRTOS-Plus/Source/Application-Protocols/network_transport/transport_mbedtls.c b/FreeRTOS-Plus/Source/Application-Protocols/network_transport/transport_mbedtls.c index e6350e56d7..f75dcafeb4 100644 --- a/FreeRTOS-Plus/Source/Application-Protocols/network_transport/transport_mbedtls.c +++ b/FreeRTOS-Plus/Source/Application-Protocols/network_transport/transport_mbedtls.c @@ -659,7 +659,7 @@ static TlsTransportStatus_t initMbedtls( mbedtls_entropy_context * pEntropyConte if( mbedtlsError != PSA_SUCCESS ) { - LogError( ( "Failed to initialize PSA Crypto implementation: %s", ( int ) mbedtlsError ) ); + LogError( ( "Failed to initialize PSA Crypto implementation: %d", ( int ) mbedtlsError ) ); returnStatus = TLS_TRANSPORT_INTERNAL_ERROR; } } @@ -832,8 +832,8 @@ void TLS_FreeRTOS_Disconnect( NetworkContext_t * pNetworkContext ) /* WANT_READ and WANT_WRITE can be ignored. Logging for debugging purposes. */ LogInfo( ( "(Network connection %p) TLS close-notify sent; " "received %s as the TLS status can be ignored for close-notify.", - ( tlsStatus == MBEDTLS_ERR_SSL_WANT_READ ) ? "WANT_READ" : "WANT_WRITE", - pNetworkContext ) ); + ( void * ) pNetworkContext, + ( tlsStatus == MBEDTLS_ERR_SSL_WANT_READ ) ? "WANT_READ" : "WANT_WRITE" ) ); } /* Call socket shutdown function to close connection. */ diff --git a/FreeRTOS-Plus/Source/Application-Protocols/network_transport/transport_mbedtls_pkcs11.c b/FreeRTOS-Plus/Source/Application-Protocols/network_transport/transport_mbedtls_pkcs11.c index a73ba3b892..3ac50f0c29 100644 --- a/FreeRTOS-Plus/Source/Application-Protocols/network_transport/transport_mbedtls_pkcs11.c +++ b/FreeRTOS-Plus/Source/Application-Protocols/network_transport/transport_mbedtls_pkcs11.c @@ -320,7 +320,7 @@ static TlsTransportStatus_t tlsSetup( NetworkContext_t * pNetworkContext, if( mbedtlsError != PSA_SUCCESS ) { - LogError( ( "Failed to initialize PSA Crypto implementation: %s", ( int ) mbedtlsError ) ); + LogError( ( "Failed to initialize PSA Crypto implementation: %d", ( int ) mbedtlsError ) ); returnStatus = TLS_TRANSPORT_INVALID_PARAMETER; } else